Improve logging output #97
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogueL90
commented
Jan 6, 2026
RogueL90
commented
- Add "idle" state
- Log state changes when they occur
- State output indicates whether video playback is looping
- Fix incorrect "process starting" log after process exits
- Add "idle" state - Log state changes when they occur - State output indicates whether video playback is looping - Fix incorrect "process starting" log after process exits
| else: | ||
| result = {"state": State.IDLE.value} | ||
|
|
||
| with state_lock: |
Contributor
There was a problem hiding this comment.
None of the code acquires or releases the state lock. The code will never execute this part
Contributor
There was a problem hiding this comment.
ok idk why it showing the snippet like that I'm a chud its the code within that with state_lock on line 422
MatthewTran22
requested changes
Jan 7, 2026
Contributor
MatthewTran22
left a comment
MatthewTran22
left a comment
There was a problem hiding this comment.
Can you add the state lock acquire and release logic, also include a screenshot showing the new change in the debug console UI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.