added parsing html for printer info #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanugarte
reviewed
Jan 6, 2026
printer/modules/collector.py
Outdated
| for element in content: | ||
| try: | ||
| pages_remaining = int(element.text.strip()) | ||
| metrics_handler.snmp_metric.labels(name="pages_remaining", ip=ip).set(pages_remaining) |
Contributor
There was a problem hiding this comment.
what does pages_remaining show? about how many pages the printer could print before running otu of ink?
Contributor
Author
There was a problem hiding this comment.
yes, ink_level shows percentage of ink left and pages_remaining shows about how many pages could still be printed
Co-authored-by: Evan Ugarte <36345325+evanugarte@users.noreply.github.com>
evanugarte
approved these changes
Jan 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made new function scrape_html