created route to email users their confirmation code #1997
Conversation
| if (!confirmCode) { | ||
| throw new Error('Confirmation code is required'); | ||
| } |
There was a problem hiding this comment.
we don't need to check this because the route already checks it
| throw new Error('Confirmation code is required'); | ||
| } | ||
|
|
||
| return { |
There was a problem hiding this comment.
can we wrap the return statement in a Promise, we should also reject the Promise if we catch an error, see unsubscribeEmail.js to see how to resolve/reject the Promise
| Thank you for signing up for membership! <br /> | ||
| Here is your confirmation code:</p> | ||
| <b>${confirmCode}</b> |
There was a problem hiding this comment.
include instructions about how they should confirm their membership, like "login to the SCE website and visit your profile to verify your membership" or something
api/cloud_api/routes/Mailer.js
Outdated
| }); | ||
| } | ||
|
|
||
| await membershipConfirmationCode(USER, req.body.recipientEmail, req.body.confirmationCode) |
There was a problem hiding this comment.
| await membershipConfirmationCode(USER, req.body.recipientEmail, req.body.confirmationCode) | |
| await membershipConfirmationCode(USER, recipientEmail, confirmationCode) |
api/cloud_api/routes/Mailer.js
Outdated
| }) | ||
| .catch((err) => { | ||
| logger.error('unable to send confirmation code: ', err); | ||
| res.sendStatus(BAD_REQUEST); |
There was a problem hiding this comment.
| res.sendStatus(BAD_REQUEST); | |
| res.sendStatus(SERVER_ERROR); |
and make sure to import this status code at the top too. i know the other routes return bad request for failures but that's wrong
api/cloud_api/routes/Mailer.js
Outdated
| logger.error('unable to send member confirmation email: ', err); | ||
| res.sendStatus(BAD_REQUEST); |
There was a problem hiding this comment.
| logger.error('unable to send member confirmation email: ', err); | |
| res.sendStatus(BAD_REQUEST); | |
| logger.error('unable to generate member confirmation email template: ', err); | |
| res.sendStatus(SERVER_ERROR); |
for issue #1987
created a simple email template and route to send confirmation codes