Pseudonymisation and FTPS #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end up in the docker image
evaluated together.
really under the right dir
files at the end of each (eg) day
meantime. Couple of other fixes.
which was triggering a mypy warning
thompson318
reviewed
Dec 23, 2025
Collaborator
thompson318
left a comment
thompson318
left a comment
There was a problem hiding this comment.
I've had a go at running this. I like the structure with the controller, hasher, and exporter in separate containers. I'll keep playing around with it.
It needs some instructions on installing PIXL (or maybe add PIXL installation to docker compose.)?
Also the config files had to be in the parent directory (../config not ./config). I also couldn't get the exporter crontab working.
src/pseudon/pseudon.py
Outdated
| ("location", pa.string()), | ||
| # decimal32 can have a maximum of 9 significant digits. | ||
| # We can go to 64 if needed but let's try and keep it compact. | ||
| # But they're not exposed?? Use 128 instead. |
Collaborator
There was a problem hiding this comment.
I don't understand this comment.
Collaborator
Author
There was a problem hiding this comment.
Thanks. Clarified
thompson318
reviewed
Dec 23, 2025
Co-authored-by: Stephen Thompson <s.thompson@ucl.ac.uk>
thompson318
approved these changes
Dec 23, 2025
Collaborator
thompson318
left a comment
thompson318
left a comment
There was a problem hiding this comment.
Looks good thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split into three containers, each with their own config files:
waveform-controller— the Emap -> CSV bit of the pipelinewaveform-exporter— converts to parquet (original and pseudon), and uploads via FTPS.waveform-hasher— from PIXL. Currently not used.There is a toy hasher built into our code just to get the full pipeline going. This will be replaced with
waveform-hasherwhen we get our credentials for the keyvault.The exporter runs cron, which doesn't currently run anything, but the individual functions are runnable as individual commands.
All data files are accessed through the mounted directory, with careful separation between pseudon and originals.