Skip to content

Conversation

@AlexV525
Copy link
Member

No description provided.

@AlexV525 AlexV525 requested a review from Copilot June 16, 2025 09:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates configuration files and code generation settings to fix CI failures, reorganize dependencies, and align generated JSON serialization with global builder options.

  • Added qrcode parameters to mock login methods to match API changes.
  • Reworked pubspec.yaml, build scripts, and GitHub Actions workflow for consistent dependency versions and CI steps.
  • Simplified annotations and JSON serialization decorators, relying on global build.yaml options and updated analysis_options.yaml.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/tencent_kit_test.dart Added optional qrcode flag to login and loginServerSide.
pubspec.yaml Moved and updated dependencies; fixed repository URL.
lib/tencent_kit_platform_interface.dart Added ignore for unnecessary library name.
lib/tencent_kit.dart Added ignore for unnecessary library name.
lib/src/model/resp.g.dart Adjusted JSON deserialization for num to int.
lib/src/model/resp.dart Removed explicit field-rename annotations in favor of global settings.
lib/src/constant.dart Converted classes to abstract final, added lint ignores.
example/pubspec.yaml Streamlined metadata; updated Flutter SDK constraint.
example/lib/main.dart Added const modifiers for widget instantiation.
example/lib/api/model/tencent_unionid_resp.g.dart Adjusted JSON deserialization for consistency.
example/lib/api/model/tencent_api_resp.g.dart Adjusted JSON deserialization for consistency.
example/build.yaml Introduced global JSON builder options (any_map, field_rename).
example/.gitignore Added pubspec.lock to ignore list.
build.yaml Introduced global JSON builder options.
analysis_options.yaml Switched to flutter_lints include and custom lint rules.
.github/workflows/build.yml Added concurrency, branch filters, caching, and unified CI jobs.
Comments suppressed due to low confidence (3)

.github/workflows/build.yml:93

  • [nitpick] Consider aligning the actions/checkout and actions/setup-java action versions between the analyze and build_android jobs (e.g., use @v4 consistently) to simplify maintenance.
        - uses: actions/checkout@v3

.github/workflows/build.yml:26

  • [nitpick] The Android build job now only runs on Ubuntu. If platform-specific issues on Windows or macOS are a concern, consider restoring those platforms to the matrix to improve CI coverage.
        matrix:
          os: [ubuntu-latest]

test/tencent_kit_test.dart:45

  • New qrcode parameter was added to login. Please add or update tests to cover both default (false) and true cases to ensure expected behavior.
      bool qrcode = false,

@AlexV525 AlexV525 merged commit 31fe4e0 into master Jun 16, 2025
3 checks passed
@AlexV525 AlexV525 deleted the fix/ci branch June 16, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants