Skip to content

Conversation

@tarcieri
Copy link
Member

This reverts commit f268e8d (#1008)

See discussion on #1008 for context

This reverts commit f268e8d (#1008)

See discussion on #1008 for context
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 90.52133% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.87%. Comparing base (44ead85) to head (35562e2).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/traits.rs 0.00% 7 Missing ⚠️
src/uint/macros.rs 83.33% 6 Missing ⚠️
src/uint/boxed/div.rs 0.00% 3 Missing ⚠️
src/uint/encoding.rs 93.54% 2 Missing ⚠️
src/uint/mul.rs 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1015      +/-   ##
==========================================
+ Coverage   79.85%   79.87%   +0.02%     
==========================================
  Files         162      163       +1     
  Lines       17575    17593      +18     
==========================================
+ Hits        14035    14053      +18     
  Misses       3540     3540              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tarcieri tarcieri merged commit f3e6291 into master Nov 25, 2025
26 checks passed
@tarcieri tarcieri deleted the revert-1008 branch November 25, 2025 15:45
@Fethbita
Copy link
Contributor

Fethbita commented Dec 2, 2025

@tarcieri, could you re-open #793 since this was reverted?

@tarcieri
Copy link
Member Author

tarcieri commented Dec 2, 2025

We should probably reopen an issue, but I don't think #793 is the right one, unless @fjarri has another idea for a design. Otherwise I'd say we tried that and it didn't work out, at least given the current limitations of the Rust type system.

@Fethbita
Copy link
Contributor

Fethbita commented Dec 2, 2025

Makes sense, maybe #228?

@tarcieri
Copy link
Member Author

tarcieri commented Dec 2, 2025

@Fethbita I'm curious if we can find a solution for what you want to do which doesn't involve having to add a bunch of bespoke sizes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants