feat: remove simpleReadFileTool completely #10254
Merged
+15
−386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Delete simpleReadFileTool.ts file - Delete simple-read-file.ts prompt description file - Delete single-file-read-models.ts types file - Remove imports and usage from presentAssistantMessage.ts - Remove imports and usage from prompts/tools/index.ts - Remove export from packages/types/src/index.ts This removes all traces of the legacy single-file read tool implementation that was used for specific models. All models now use the standard read_file tool.
Contributor
Author
Review complete. No issues found. This PR cleanly removes the Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
hannesrudolph
added
the
Issue/PR - Triage
mrubens
approved these changes
Dec 21, 2025
mrubens
approved these changes
Dec 25, 2025
dosubot
bot
added
the
size:L
Contributor
Author
Reviewing your PR now. Feedback coming soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely removes the simpleReadFileTool and all its dependencies, leaving no trace or legacy fallback.
Changes Made
simpleReadFileTool.tsfilesimple-read-file.tsprompt description filesingle-file-read-models.tstypes filepresentAssistantMessage.tsprompts/tools/index.tspackages/types/src/index.tsTesting
All models now use the standard
read_filetool implementation.View task on Roo Code Cloud
Important
The PR removes the
simpleReadFileTooland its dependencies, ensuring all models use the standardread_filetool implementation.simpleReadFileTool.ts,simple-read-file.ts, andsingle-file-read-models.ts.presentAssistantMessage.tsandindex.ts.read_filetool implementation.This description was created by
for b48da53. You can customize this summary. It will automatically update as commits are pushed.