-
Notifications
You must be signed in to change notification settings - Fork 4
Feat/cs/fix null objs #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Null objects and improves performance through allocation optimization and depth limits. The changes address issue #5 by introducing null value handling and prevent potential infinite loops in object traversal.
- Adds
Nullvariant toOutputDataenum for representing null values - Implements depth limits and item count limits in DFS traversal to prevent infinite loops
- Optimizes memory allocation by using estimated capacities based on data size
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/models/output_data.rs | Adds Null variant to OutputData enum with display formatting |
| src/deserializer/typedstream.rs | Handles null objects and optimizes allocation with estimated capacities |
| src/deserializer/iter.rs | Adds depth/item limits to primitive collection and print functions |
| src/error.rs | Changes pointer formatting from decimal to hexadecimal |
| src/lib.rs | Adds test case for parsing large files with null objects |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Nullobjects for Any way to read this? #5