Skip to content

Conversation

@ReagentX
Copy link
Owner

@ReagentX ReagentX self-assigned this Aug 28, 2025
@ReagentX ReagentX added bug Something isn't working enhancement New feature or request labels Aug 28, 2025
@ReagentX ReagentX moved this to In Progress in 3.1: Foothill Clover Aug 28, 2025
@ReagentX ReagentX requested a review from Copilot August 28, 2025 20:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Null objects and improves performance through allocation optimization and depth limits. The changes address issue #5 by introducing null value handling and prevent potential infinite loops in object traversal.

  • Adds Null variant to OutputData enum for representing null values
  • Implements depth limits and item count limits in DFS traversal to prevent infinite loops
  • Optimizes memory allocation by using estimated capacities based on data size

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/models/output_data.rs Adds Null variant to OutputData enum with display formatting
src/deserializer/typedstream.rs Handles null objects and optimizes allocation with estimated capacities
src/deserializer/iter.rs Adds depth/item limits to primitive collection and print functions
src/error.rs Changes pointer formatting from decimal to hexadecimal
src/lib.rs Adds test case for parsing large files with null objects

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ReagentX ReagentX merged commit 9a262ae into develop Aug 28, 2025
1 check passed
@ReagentX ReagentX deleted the feat/cs/fix-null-objs branch August 28, 2025 23:10
@ReagentX ReagentX moved this from In Progress to Done in 3.1: Foothill Clover Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants