Skip to content

Conversation

@ReagentX
Copy link
Owner

@ReagentX ReagentX commented Aug 29, 2025

@ReagentX ReagentX self-assigned this Aug 29, 2025
@ReagentX ReagentX added the enhancement New feature or request label Aug 29, 2025
@ReagentX ReagentX requested a review from Copilot August 29, 2025 16:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds no_std support to the codebase, allowing it to be used in environments without the standard library by switching to core types and allocator-based collections.

Key changes:

  • Add #![no_std] attribute and conditional std feature
  • Replace std:: types with core:: equivalents for basic functionality
  • Import alloc::vec::Vec for heap-allocated collections

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/lib.rs Adds no_std attribute and conditional std extern crate
src/error.rs Replaces std types with core equivalents for error handling
src/models/output_data.rs Updates Display trait implementation to use core::fmt
src/models/types.rs Adds alloc imports for Vec usage
src/models/archived.rs Adds alloc::vec::Vec import
src/deserializer/typedstream.rs Adds alloc imports for collections
src/deserializer/string.rs Updates string parsing to use core::str
src/deserializer/iter.rs Updates iterator types and adds std feature guards for print functions
src/deserializer/header.rs Updates test imports for no_std compatibility
src/deserializer/consumed.rs Replaces std::ops with core::ops for Deref traits
Cargo.toml Adds std feature flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ReagentX
Copy link
Owner Author

ReagentX commented Aug 29, 2025

Seems reasonable; no performance impact in my testing. Thank you for your contribution!

@ReagentX ReagentX merged commit 73485ba into develop Aug 29, 2025
1 check passed
@ReagentX ReagentX deleted the no-std branch August 29, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants