-
Notifications
You must be signed in to change notification settings - Fork 4
Feat/cs/cleanup #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7204a7a to
774b1ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR cleans up the codebase while adding two new features to simplify working with typed stream data: a new helpers method primitives() in PropertyIterator and an iter_root() shortcut for TypedStreamDeserializer. It also updates documentation, removes debug logs, and renames a module for clarity.
- Added new helper primitives() to extract primitive values from the deserialized object graph.
- Introduced iter_root() to streamline property resolution from the root object.
- Improved documentation, refactored module names, and removed debug print statements.
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/models/types.rs | Reformatted import grouping for cleaner code organization. |
| src/models/output_data.rs | Updated doc comments and implemented helper methods and Display trait. |
| src/models/mod.rs | Renamed module "archivable" to "archived" for clarity. |
| src/models/class.rs | Changed access level for Class::new and updated related docs. |
| src/models/archived.rs | Added clarifying documentation for archived objects. |
| src/lib.rs | Updated re-exports and removed obsolete debug/log comments. |
| src/error.rs | Enhanced documentation with code examples for error handling. |
| src/deserializer/typedstream.rs | Introduced iter_root(); removed debug println! statements; updated docs. |
| src/deserializer/string.rs | Minor doc comment updates regarding UTF-8 string reading. |
| src/deserializer/read.rs | Cleaned up import formatting and updated documentation references. |
| src/deserializer/number.rs | Adjusted import ordering and updated test module imports. |
| src/deserializer/mod.rs | Minor documentation update on module purpose. |
| src/deserializer/iter.rs | Added doc comments for the new primitives() method and improved examples. |
| src/deserializer/header.rs | Updated header validation docs for clarity. |
| README.md | Revised language and formatting for better clarity and presentation. |
primitives()toPropertyIteratoriter_root()shortcut toTypedStreamDeserializerto cut down on boilerplateDisplayand helper methods forOutputData