Skip to content

Conversation

@HughParsonage
Copy link
Member

Removes the STOP from the parallel region, which I suspect (though have not proven) is the cause of the segfault on CRAN for v1.18.0. Even if it not ultimately the cause, causing error inside such a region is asking for trouble.

Existing tests trigger the segfault.

@codecov
Copy link

codecov bot commented Dec 27, 2025

Codecov Report

❌ Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.96%. Comparing base (2c94b8c) to head (2e53105).

Files with missing lines Patch % Lines
src/forder.c 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7535      +/-   ##
==========================================
- Coverage   98.97%   98.96%   -0.01%     
==========================================
  Files          87       87              
  Lines       16732    16745      +13     
==========================================
+ Hits        16560    16572      +12     
- Misses        172      173       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HughParsonage HughParsonage marked this pull request as draft December 27, 2025 01:24
@HughParsonage
Copy link
Member Author

Noticed some other spots where STOP is called

@github-actions
Copy link

github-actions bot commented Dec 27, 2025

No obvious timing issues in HEAD=fix/hp/7519-stop-in-omp-region
Comparison Plot

Generated via commit 2e53105

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 52 seconds
Installing different package versions 22 seconds
Running and plotting the test cases 4 minutes and 3 seconds

@ben-schwen
Copy link
Member

As pointed out by Ivan, this might not be a problem of us, but of base (where the original code was donated by data.table QQ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants