-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[utest][smp_call]:Add standardized documentation for SMP Call Smoke Test #11014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[utest][smp_call]:Add standardized documentation for SMP Call Smoke Test #11014
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-09 18:22 CST)
📝 Review Instructions
|
a7ca518 to
dc1977d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive standardized documentation blocks to four SMP (Symmetric Multi-Processing) Call smoke test files. The documentation provides detailed information about test objectives, scenarios, verification metrics, dependencies, and expected results for each test case.
Key Changes:
- Added structured documentation blocks following a consistent template across all four test files
- Updated Change Log entries with new modification records
- Enhanced code maintainability through detailed inline documentation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| components/drivers/smp_call/utest/smp_001_tc.c | Added documentation for SMP Call Smoke 001 Test covering synchronous blocking calls with CPU mask validation |
| components/drivers/smp_call/utest/smp_002_tc.c | Added documentation for SMP Call Smoke 002 Test covering thread-safety under concurrent calls from multiple CPUs |
| components/drivers/smp_call/utest/smp_003_tc.c | Added documentation for SMP Call Smoke 003 Test covering asynchronous high-contention scenarios |
| components/drivers/smp_call/utest/smp_004_tc.c | Added documentation for SMP Call Smoke 004 Test covering re-entrant SMP calls and nested IPI scenarios |
| * | ||
| * Test Objectives: | ||
| * - Validate asynchronous rt_smp_call_cpu_mask() reliability under high-contention. | ||
| * - Ensure no Inter-Processor Interrupts are lost when fired rapidly without waiting. |
Copilot
AI
Dec 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space in documentation / 文档中有多余空格
English: There are two consecutive spaces between "Interrupts" and "are". Please remove the extra space.
中文:在"Interrupts"和"are"之间有两个连续的空格。请删除多余的空格。
| * - Ensure no Inter-Processor Interrupts are lost when fired rapidly without waiting. | |
| * - Ensure no Inter-Processor Interrupts are lost when fired rapidly without waiting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
dc1977d to
d358971
Compare
|
@Rbb666 我检查了 Static code analysis 的失败原因:
|
建议新开一个,然后引用下,我按照顺序合并 |
|
修复bug的pr已经提交了 |
拉取/合并请求描述:(PR description)
Relates to #10985
[
为什么提交这份PR (why to submit this PR)
Add standardized documentation for SMP Call Smoke Test
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
BSP:
.config:
action:
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up