[drivers][ofw] Update OFW #11004
[drivers][ofw] Update OFW #11004
Conversation
The bubble up should stop when the #xxx-cells is match. Signed-off-by: GuEe-GUI <2991707448@qq.com>
Signed-off-by: GuEe-GUI <2991707448@qq.com>
Like "earlycon=hvc earlycon=sbi"... Signed-off-by: GuEe-GUI <2991707448@qq.com>
"stdout-path" has path and option, we should find the console device by dts path. Signed-off-by: GuEe-GUI <2991707448@qq.com>
|
👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。 🛠 操作步骤 | Steps
完成后，提交将自动更新至 如有问题欢迎联系我们，再次感谢您的贡献！💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-09 17:55 CST)
📝 Review Instructions
|
Some device is not a PIC driver but platform driver. We should request it auto. Signed-off-by: GuEe-GUI <2991707448@qq.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses bugs in the Open Firmware (OFW) driver subsystem and improves console setup functionality. The changes fix fundamental issues with device tree parsing and enhance the earlycon (early console) initialization process.
Key changes:
- Fixed FDT address/size cells parsing to stop at the first valid parent node
- Enhanced stdout-path handling to support alias resolution
- Improved interrupt controller device initialization with lazy loading
- Added support for earlycon configurations using only option names
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| components/drivers/ofw/raw.c | Fixed fdt_io_addr_cells and fdt_io_size_cells to break after finding the first valid #address-cells or #size-cells property in parent nodes |
| components/drivers/ofw/ofw.c | Added alias resolution logic for stdout-path when it doesn't start with '/' to properly find console device through aliases |
| components/drivers/ofw/irq.c | Added rt_platform_ofw_request call to ensure interrupt controller device is initialized before mapping IRQs; included platform.h header |
| components/drivers/ofw/io.c | Code cleanup: removed extra blank line in function signature |
| components/drivers/ofw/fdt.c | Enhanced earlycon option parsing to support both comma and space delimiters; added logging for earlycon configurations without MMIO address |
| components/drivers/ofw/base.c | Code cleanup: removed extra blank line |
|
@Rbb666 done |
2 participants
拉取/合并请求描述：(PR description)
[
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up