-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: cursor based scheduling #8181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Varixo
wants to merge
37
commits into
build/v2
Choose a base branch
from
v2-cursors
base: build/v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,281
−6,027
Draft
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
0d70d3d
chore(core): _getQContainerElement only on element
wmertens 1ee27e5
chore(core): _run should not wait
wmertens 04746ad
chore(serdes): name SerializationBackRef
wmertens 9f7ca25
refactor(core): ignore className
wmertens 78e966c
wip cursors scheduling
wmertens c366b10
more logging
wmertens a1f7314
feat(cursors): pass container to vnode functions
Varixo 6b0a632
chore(types): add event handler type tests
wmertens 7128b3f
feat(cursors): migrate to journal
Varixo 233e581
feat(cursors): handle changing component props
Varixo 1bd1df9
feat(cursors): fix some promises cases
Varixo ac95674
feat(cursors): compute chore impl
Varixo 41397e6
feat(cursors): fix apply journal
Varixo 62afb5a
feat(cursors): fix handling errors
Varixo 91d1ec5
feat(cursors): migrate to single cursor prop
Varixo e2d539d
fix(cursors): setting falsy prop
Varixo c724518
fix(cursors): vnode_diff unit tests
wmertens ed3a716
fix(cursors): merge cursors during vnode-diff and fix debug to string
Varixo f680f03
feat(cursors): initialize render context with waitOn
Varixo 97be9d8
feat(cursors): propogate dirty flag to blocking cursor
Varixo 75ddaa7
feat(cursors): fix async computed signals
Varixo 13e0be4
feat(cursor): process dirty non-projection vnodes first
Varixo 46e10e2
feat(cursors): dont execute qrls for deleted vnodes
Varixo ddf34f6
feat(cursors): fix resource tests
Varixo f36b102
feat(cursors): fix visible tasks
Varixo 5d89d7b
feat(cursors): ssr integration
Varixo 2f0d2b6
feat(cursors): assign key as : prop value
Varixo 17ee93e
feat(cursors): fix setting innerHTML
Varixo 4b5eca2
feat(cursors): fix catching error for runQrl
Varixo 780af82
feat(cursors): fix hoisting styles
Varixo 4b9644d
feat(cursors): retry on promise while invalidate signal
Varixo 215f74e
feat(cursors): remove old scheduler tests
Varixo b5d2bbd
feat(cursors): fix vnode tests
Varixo 9438a47
feat(cursors): misc changes
Varixo 15edb8d
feat(cursors): fix most resource tests
Varixo db50ed7
feat(cursors): async computed serialization fix
Varixo 6bd336f
feat(cursors): cleanup old code and fix build
Varixo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't that break the benefits of html streaming? If you hoist the styles to the top, then all styles need to be downloaded before the html continues rendering. Whereas if only the styles that are needed for the top navbar are loaded then it can be rendered right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What this does it take all the inline styles that were emitted by
use*Styles$and move them into head, so that they don't interfere with DOM handling.This is the way it is in v1 as well, and it should not have any effect on page loading.