Skip to content

Conversation

@blacks1ne
Copy link
Contributor

@blacks1ne blacks1ne commented Nov 23, 2025

A major dependencies bump and update to go 1.24 (already in use by the node) while ensuring all tests succeed.

  1. The only remaining challenge is the lint tests some of which install tools like staticcheck and golint during runtime. This causes the addition of the dependencies to the pebble's root go.mod upon execution. However, after execution the IDE tools suggest that the added go.mod dependencies are unnecessary.
    I checked the original pebble repo and it seems like they're trying to localize these runtime deps in a separate internal/devtools dir with its own go.mod. However, cloning the original pebble repo I cannot get the lint tests to succeed.
    So some advice here would be appreciated.
  2. Another question is that this is the only module with the original project path instead of Q-specific one. I am not sure if that needs to be changed or not. I also added a replace in the go.mod pointing to our module's local path, please validate if that is something useful.
  3. Last, but not least, it seems there are many changes in the original pebble project. I suppose our pebble fixes made our fork rather incompatible, meaning it makes little sense to merge upstream changes. However, a confirmation on this point would be useful.
  4. I still need to upgrade zstd

@blacks1ne blacks1ne force-pushed the upgrade-pebble-and-fix-tests branch from 55ba977 to 2435e92 Compare November 23, 2025 13:11
@blacks1ne blacks1ne mentioned this pull request Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant