Skip to content

Conversation

@blacks1ne
Copy link
Contributor

No description provided.

@blacks1ne blacks1ne changed the title Remove unnecessary space char at the end of French flag unicode that breaks logo format Remove unnecessary space char at the end of French flag unicode that breaks Q logo format Oct 28, 2025
*blockchar,
*ver,
"\U0001F1EB\U0001F1F7 ",
"\U0001F1EB\U0001F1F7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the space there because a lot of the terminal emulators don't correctly handle combining unicode characters correctly, causing it to treat the two unicode points as one character (correct), but has a double width (also correct), but does not apply double width to the character when printing, resulting in overlapping flags. In some cases, terminals need the extra space, in others, they don't. If we're keeping this easter egg for longer than 2.1.0, we should probably find a way to determine how double-width characters render on a given terminal. Note: I don't know if there's a standard way to do that, many terminal emulators have issues that crop up around this from time to time, and are prioritized low or "not fixing" (e.g. microsoft/terminal#16852)

@blacks1ne blacks1ne changed the title Remove unnecessary space char at the end of French flag unicode that breaks Q logo format Determine how double-width characters render on a given terminal before adjusting chars used for Q logo Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants