Features/daqmove improvements #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astroloba
force-pushed
the
features/daqmove_improvements
branch
from
5439446 to
62cdef5
Compare
seb5g
requested changes
Jun 24, 2025
Contributor
seb5g
left a comment
seb5g
left a comment
There was a problem hiding this comment.
After discussion we should add a self.is_!aster clause in the close methods
| """Terminate the communication protocol""" | ||
| ## TODO for your custom plugin | ||
| raise NotImplemented # when writing your own plugin remove this line | ||
| raise NotImplementedError # when writing your own plugin remove this line |
Contributor
There was a problem hiding this comment.
maybe we should add a self.is_master clause??
| def close(self): | ||
| """Terminate the communication protocol""" | ||
| ## TODO for your custom plugin | ||
| raise NotImplemented # when writing your own plugin remove this line |
| def close(self): | ||
| """Terminate the communication protocol""" | ||
| ## TODO for your custom plugin | ||
| raise NotImplemented # when writing your own plugin remove this line |
Contributor
Author
|
Commit d56df09 proposes a master/slave implementation in |
seb5g
approved these changes
Jul 1, 2025
Contributor
|
thks for this first PyMoDAQ PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4 small improvements:
NotImplementedtoNotImplementedErrorfor all instances indaq_moveanddaq_viewerfiles..stop_motion()code indaq_moveto set it the same as other methods in the class..axis_unitto explicitly set theDataActuatorunit used (for getting current value and for conversion before sending to controller methods) to the one configured in the class parameters..close(),.ini_stage()(daq_move) and.ini_detector()(daq_viewerxD)