mise à jour en mode signal_recovery #6
Conversation
| A given parameter (within detector_settings) whose value has been changed by the user | ||
| """ | ||
|
|
||
| def commit_settings(self, param: Parameter) -> None: |
There was a problem hiding this comment.
this is a error, could you clean that please? those two def declaration!!
There was a problem hiding this comment.
Hey sorry ! just discovering all this. Think it is ok on my branch now.
| controller: object | ||
| Controller of the daq_move | ||
| """ | ||
| self.ini_stage_init(slave_controller=controller) |
There was a problem hiding this comment.
you can actually remove this line and add the one below
| self.settings.child('address').value() | ||
| ) | ||
| self.controller = SR830ThreadSafe(adapter) | ||
|
|
There was a problem hiding this comment.
else:
self.controller = controller
| info = self.controller.id | ||
| self.settings.child('id').setValue(info) | ||
| initialized = True | ||
| self.ini_detector_init(slave_controller=controller) |
There was a problem hiding this comment.
same remove this line and add a
else:
self.controller = controller
| for channel in CHANNELS: | ||
| assert hasattr(SR830ThreadSafe, channel) | ||
|
|
||
| class ChannelGroup(GroupParameter): |
There was a problem hiding this comment.
actually this is a wrong idea to do so because it won't be properly saved for a given configuration. Why would you change that and not use the already existing way to select the channels?? and magnitude and phase was existing as the R and theta channels??
2 participants
No description provided.