fix of readout, gain, grating #15
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Aim of the pull request
We have a Shamrock spectrometer from andor equipped with a Newton EMCCD in the lab that we cant to control using PyMoDAQ. We couldn't modify the horizontal readout speed and the gain of the EMCCD. There were only 2 gratings accessible from PyMoDAQ even though the spectrometer has three gratings.
This pull request fixes those issues and it was tested on the described hardware.
Summary of the modifications
Files modified
\src\pymodaq_plugins_andor\daq_move_plugins\daq_move_Shamrock.py\src\pymodaq_plugins_andor\daq_viewer_plugins\plugins_2D\daq_2Dviewer_AndorCCD.py\src\pymodaq_plugins_andor\hardware\sdk2.pyGratings issue
I modified the
ini_spectrofunction so that the name of each grating is different so that all gratings appear in the parameter list.Gain issue
I added a new parameter in the settings and modified the
commit_settingsaccordingly. The parameters bounds are updated inini_camera.Horizontal readout speed (HSSpeed)
To control HSSpeed, the type of camera (EMCCD or conventional) has to be set. Additionally there may be several Analog to Digital (AD) channels configured, so the AD channel index has also to be specified. The number of available AD channels and the CCD type are set at init using
init_AD_channels. These values are now stored in theAndorSDKobject.In PyMoDAQ, the parameter contains a 'AD channels' group which contain a 'ad_channel_#' list for each available AD channel. Each list displays the avalaible horizontal readout speeds.
To be done soon
To be done later