Skip to content

Conversation

@digit01Wave
Copy link
Contributor

#1115
This PR

  • defaults embedded and blazor to true on creation
  • removes references to Model.Event.AllowBlazor in code

@tabascq
Copy link
Contributor

tabascq commented Nov 29, 2025

Does this make the page for /Teams/List dead code, or is there another entry point to it?

@digit01Wave
Copy link
Contributor Author

Does this make the page for /Teams/List dead code, or is there another entry point to it?

It is referred to in some partial cshtmls from past events (nipd2020/homePartial.cshtml, nipd2021/homepartial.cshtml). To not break those i was going to leave it.

@tabascq
Copy link
Contributor

tabascq commented Nov 29, 2025

Does this make the page for /Teams/List dead code, or is there another entry point to it?

It is referred to in some partial cshtmls from past events (nipd2020/homePartial.cshtml, nipd2021/homepartial.cshtml). To not break those i was going to leave it.

I don't think it is critically important to preserve the signup procedure for a five year old event, but why not change these to /Teams/Signup?

I'm just trying to keep us from needing to perpetually maintain code that nobody will ever run.

@digit01Wave
Copy link
Contributor Author

Does this make the page for /Teams/List dead code, or is there another entry point to it?

It is referred to in some partial cshtmls from past events (nipd2020/homePartial.cshtml, nipd2021/homepartial.cshtml). To not break those i was going to leave it.

I don't think it is critically important to preserve the signup procedure for a five year old event, but why not change these to /Teams/Signup?

I'm just trying to keep us from needing to perpetually maintain code that nobody will ever run.

That is fair. I removed all references to /List and replaced it with signup

@tabascq
Copy link
Contributor

tabascq commented Nov 29, 2025

Thanks! I'd like @morganbr to ring in on this since he did the original signup conversion and may know of a wrinkle we have forgotten, but I don't see any issues. I'm not signing off just so we remember that Morgan has to look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants