Small changes so it compiles (at least on my system) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(hopefully) equivalent but cleaner Also added readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After researching for a while, I found I needed to manually add the required package repositories to a NuGet config so it could find the required packages. I also changed the PostBuild line so it hopefully does something equivalent but more generalised. (The original code runs the command, which checks for PureDark's username, and if it fails then it has an error. With the way I rewrote it, it should check for PureDark's username first, then copy using built-in functions, or just skip it if the condition isn't met.)
Also wasn't sure if it was necessary, but I added the readme file from the Thunderstore download and a small section on building from the command line.
You're welcome to make any changes you want, of course. But I hope this helps in some way.