enhancement: use placeholder for node name in device plugin ConfigMap template #873
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the default node name in ConfigMap from a specific name to a placeholder to make it clearer that users need to replace it with their actual node name. Signed-off-by: Nimbus318 <136771156+Nimbus318@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
PR Overview
This PR enhances the device plugin ConfigMap template by replacing the hard-coded node name with a clear placeholder, making it evident to users that they must substitute it with their actual node name.
- Replaces "m5-cloudinfra-online02" with "" in the ConfigMap template
Reviewed Changes
| File | Description |
|---|---|
| charts/hami/templates/device-plugin/configmap.yaml | Updated the node name to a placeholder indicating that users need to supply the actual node name. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
charts/hami/templates/device-plugin/configmap.yaml:13
- [nitpick] Consider adding an inline comment to clarify that '' is a placeholder and must be replaced with the actual node name before deployment.
"name": "<your-node-name>",
Member
|
#493 |
Contributor
|
/lgtm |
Member
/lgtm |
Contributor
|
Conflict can't resolve base current master, so close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Several users have reported issues where the device plugin configuration doesn't take effect because they didn't modify the default node name in the ConfigMap. This PR replaces the specific node name with a placeholder to make it more obvious that users need to replace it with their actual node name.
Changes:
m5-cloudinfra-online02to<your-node-name>in the device plugin ConfigMap template to better indicate that this value needs to be replacedWhich issue(s) this PR fixes:
Fixes #811
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Yes. Users will see a more intuitive placeholder in the ConfigMap template that clearly indicates they need to replace it with their actual node name.