Use container device idx #742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elrondwong
commented
Dec 26, 2024
elrondwong
commented
elrondwong
force-pushed
the
use-container-device-idx
branch
from
764b2bf to
9982e83
Compare
- Completed TODO: current Idx cannot use, because EncodeContainerDevices method - Updated test cases to include `index` in the `want` structure. - Ensured better coverage of scenarios involving `index` handling. chore: update .gitignore to ignore build and test output - Added `_output/` directory to `.gitignore` to ignore generated build artifacts. - Added `coverage.out` to `.gitignore` to ignore test coverage reports. Signed-off-by: elrondwong <gfengwong@gmail.com>
elrondwong
force-pushed
the
use-container-device-idx
branch
from
743cc1e to
89f62f5
Compare
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
|
@elrondwong can you rebase main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.