-
Notifications
You must be signed in to change notification settings - Fork 0
Road to 3.0.0-beta-2 #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r with diverse style elements. Modern cases there will build with bootstrap or something else. The User should also customize the viewer, and this framework should be only delivering the api content.
…uid. $uid and $cluid are the same identifier.
…st_can_copy_delete_channelgroup to validate channelGroupCopy
…rmission handling and missing type fix
…ange test_can_ban_user to chaining Client.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spend a lot of time to increase the coverage rate and fix issues during tests
Changes Made
ChannelGroup.php -> refers to -> Server.php
there missing type decleration
arrayor an
intinstead ofstringexample:clientGetByName(int $name)new ReflectionClass('TeamSpeak3');should benew ReflectionClass(TeamSpeak3::class);Additional Notes
Maybe the integration in current projects with Version below 3.x need a few updates
Merge Request Checklists