Skip to content

Conversation

@MajorOli
Copy link
Collaborator

@MajorOli MajorOli commented Nov 2, 2025

Description

Spend a lot of time to increase the coverage rate and fix issues during tests

Changes Made

  • Breaking Change: Remove viewer function
  • Fix type errors on chaining functions. Example:

ChannelGroup.php -> refers to -> Server.php

    public function permAssign(int $permid, int $permvalue): void
    {
        $this->getParent()->channelGroupPermAssign($this->getId(), $permid, $permvalue);
    }

there missing type decleration array

public function channelGroupPermAssign(int $cgid, int|array $permid, int|array $permvalue): void
...

or an int instead of string example: clientGetByName(int $name)

  • Fix missing full qualified Classname
    new ReflectionClass('TeamSpeak3'); should be new ReflectionClass(TeamSpeak3::class);
  • Remove meta data from reply results
  • Extend Tests to validate functions are working when affected multiple clients

Additional Notes

Maybe the integration in current projects with Version below 3.x need a few updates

Merge Request Checklists

  • Code follows project coding guidelines.
  • Documentation reflects the changes made.
  • I have already covered the unit testing.

…r with diverse style elements. Modern cases there will build with bootstrap or something else. The User should also customize the viewer, and this framework should be only delivering the api content.
…uid. $uid and $cluid are the same identifier.
…st_can_copy_delete_channelgroup to validate channelGroupCopy
…ange test_can_ban_user to chaining Client.php
@MajorOli MajorOli merged commit 0ec1f2e into main Nov 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review: find issues in public projects to be sure i haven't missed anything

2 participants