Skip to content

Fix various notices #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
r-a-y wants to merge 4 commits into
base: 5.2.x
Choose a base branch
from
Open

Fix various notices #1061

r-a-y wants to merge 4 commits into from

Conversation

@r-a-y
Copy link
Contributor

@r-a-y r-a-y commented May 26, 2020 •
edited
Loading

Hi,

This PR fixes various notices for PHP 7.3+:

  • Deprecated get_magic_quotes_gpc() notice -- deprecated as of PHP 7.4. I've replaced this with a strpos() slash check.
  • "preg_match(): Compilation failed: invalid range in character class at offset 4" warning -- notice shows up in PHP 7.3+. Fix is to escape the hyphen in the preg_match() call.
  • "Array to string conversion" notice -- not related to PHP 7.3, but came across this while checking the "PressForward > Nominated" page. View the commit message for more info.

Let me know if you have any questions.

r-a-y added 4 commits May 25, 2020 22:42
@r-a-y
Fix deprecated get_magic_quotes_gpc() notice.
8ba5798 
Replaced it with a strpos() check for a slash.
@r-a-y
Fix "Array to string conversion" notice.
4428b08 
For the 'nominators' key, the $itemPart is a multi-dimensional array.
We need to grab the keys of the array.
@r-a-y
Fix "preg_match(): Compilation failed: invalid range in character cla…
b5f07ed 
…ss at offset 4" warning.

Hyphen needs to be escaped in preg_match().
@r-a-y
Fix "preg_match_all(): Compilation failed: invalid range in character…
fed17a0 
… class at offset 4" warning.

Hyphen needs to be escaped in preg_match_all().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@r-a-y