fix(Roblox): fix typos and improve variable assignments #10279
Conversation
Signed-off-by: BuddyWinte <BuddyWinte@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,4 +1,5 @@ | |||
| import { Assets } from 'premid' | |||
| // import { Assets } from 'premid' | |||
| import { Presence, PresenceData, Assets } from 'premid'; // TS hates when you dont define it all. | |||
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
| @@ -1,4 +1,5 @@ | |||
| import { Assets } from 'premid' | |||
| // import { Assets } from 'premid' | |||
| import { Presence, PresenceData, Assets } from 'premid'; // TS hates when you dont define it all. | |||
Check failure
Code scanning / PMD
Makes sure the TypeScript files are correct Error
| @@ -1,4 +1,5 @@ | |||
| import { Assets } from 'premid' | |||
| // import { Assets } from 'premid' | |||
| import { Presence, PresenceData, Assets } from 'premid'; // TS hates when you dont define it all. | |||
Check failure
Code scanning / ESLint
Enforce consistent usage of type imports Error
| @@ -1,4 +1,5 @@ | |||
| import { Assets } from 'premid' | |||
| // import { Assets } from 'premid' | |||
| import { Presence, PresenceData, Assets } from 'premid'; // TS hates when you dont define it all. | |||
Check failure
Code scanning / ESLint
Enforce sorted named imports. Error
| @@ -1,4 +1,5 @@ | |||
| import { Assets } from 'premid' | |||
| // import { Assets } from 'premid' | |||
| import { Presence, PresenceData, Assets } from 'premid'; // TS hates when you dont define it all. | |||
Check failure
Code scanning / ESLint
Require or disallow semicolons instead of ASI Error
| ) | ||
| const newUrl = new URL(href) | ||
| const searchResult = newUrl.searchParams?.get('Keyword') ?? newUrl.searchParams?.get('query') | ||
| const searchResult = (newUrl.searchParams.get('keyword') ?? newUrl.searchParams.get('query'))?.toLowerCase() ?? null; |
Check failure
Code scanning / ESLint
Require or disallow semicolons instead of ASI Error
| .querySelector('.avatar-card-link.avatar-image-link') | ||
| ?.querySelector('img') | ||
| ?.getAttribute('src') ?? ActivityAssets.Logo | ||
| const profileImg = document.querySelector<HTMLImageElement>('.avatar-card-link.avatar-image-link img'); |
Check failure
Code scanning / ESLint
Require or disallow semicolons instead of ASI Error
| ?.querySelector('img') | ||
| ?.getAttribute('src') ?? ActivityAssets.Logo | ||
| const profileImg = document.querySelector<HTMLImageElement>('.avatar-card-link.avatar-image-link img'); | ||
| presenceData.largeImageKey = profileImg?.src ?? ActivityAssets.Logo; |
Check failure
Code scanning / ESLint
Require or disallow semicolons instead of ASI Error
| break | ||
| } | ||
| case pathname.includes('/u/'): { | ||
| //const user = document.querySelector('.username')?.textContent |
Check failure
Code scanning / ESLint
Enforce consistent spacing after the `//` or `/*` in a comment Error
| //const user = document.querySelector('.username')?.textContent | ||
| // for some reason, the devforum has different classes per user? weird? | ||
| const user = document.querySelector('.username')?.textContent | ||
| ?? document.querySelector('.user-card-name')?.textContent; |
Check failure
Code scanning / ESLint
Require or disallow semicolons instead of ASI Error
theusaf
changed the title
2 participants
Description
Improved the Roblox Presence activity for PreMiD:
profileImgscoping bug.UpdateDatahandler.Acknowledgements
npm run lintScreenshots
Proof showing the creation/modification is working as expected