Skip to content

round value with decimal precision #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fl4p wants to merge 2 commits into
base: master
Choose a base branch
from
Open

round value with decimal precision #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82b96fd
round value with decimal precision
fl4p Nov 29, 2016
ff47852
use precision fix for non-integer steps
fl4p Dec 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions iron-range-behavior.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,16 +91,19 @@
}

var numSteps = Math.round((value - this.min) / this.step);
if (this.step < 1) {
var stepStr = this.step.toString();
var stepPointAt = stepStr.indexOf('.');
if (stepPointAt != -1) {
/**
* For small values of this.step, if we calculate the step using
* For non-integer values of this.step, if we calculate the step using
* `Math.round(value / step) * step` we may hit a precision point issue
* eg. 0.1 * 0.2 = 0.020000000000000004
* http://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html
*
* as a work around we can divide by the reciprocal of `step`
* as a work around we can round with the decimal precision of `step`
*/
return numSteps / (1 / this.step) + this.min;
var precision = Math.pow(10, stepStr.length - stepPointAt - 1);
return Math.round((numSteps * this.step + this.min) * precision) / precision;
} else {
return numSteps * this.step + this.min;
}
Expand Down