Skip to content

fix(PlayKeychain): a crash when storing dictionary #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheMoonThatRises merged 3 commits into from
Oct 8, 2025
Merged

fix(PlayKeychain): a crash when storing dictionary #196

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
532a2fb
fix(PlayKeychain): a crash when storing dictionary
xKingDark Aug 15, 2025
ae5adaf
Update PlayedApple.swift
xKingDark Sep 12, 2025
c5f6311
Update PlayedApple.swift
xKingDark Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions PlayTools/MysticRunes/PlayedApple.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,25 @@ public class PlayKeychain: NSObject {
}

if attributes["class"] as? String == "keys" {
// kSecAttrKeyType is stored as `type` in the dictionary
// kSecAttrKeyClass is stored as `kcls` in the dictionary
let keyAttributes = [
kSecAttrKeyType: attributes["type"] as! CFString, // swiftlint:disable:this force_cast
kSecAttrKeyClass: attributes["kcls"] as! CFString // swiftlint:disable:this force_cast
]
let keyData = vData as! Data // swiftlint:disable:this force_cast
let key = SecKeyCreateWithData(keyData as CFData, keyAttributes as CFDictionary, nil)
result?.pointee = Unmanaged.passRetained(key!)
return errSecSuccess
if let keyDataValue = vData as? Data {
// kSecAttrKeyType is stored as `type` in the dictionary
// kSecAttrKeyClass is stored as `kcls` in the dictionary
let keyAttributesDictionary = [
kSecAttrKeyType: attributes["type"] as? String
?? (attributes[kSecAttrKeyType as String] as? String),
kSecAttrKeyClass: attributes["kcls"] as? String
?? (attributes[kSecAttrKeyType as String] as? String)
]
if let key = SecKeyCreateWithData(
keyDataValue as CFData,
keyAttributesDictionary as CFDictionary,
nil
) {
result?.pointee = Unmanaged.passRetained(key)
return errSecSuccess
}
}
return errSecBadReq
}
result?.pointee = Unmanaged.passRetained(vData)
return errSecSuccess
Expand Down