-
Notifications
You must be signed in to change notification settings - Fork 40
Make a differentiable version of FourierRZToroidalSurface.constant_offset_surface
#2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| NOTE: Must have the toroidal angle as the cylindrical toroidal angle | ||
| in order for this algorithm to work properly | ||
| NOTE: this function lacks the checks of the constant_offset_surface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only is differentiable though if params is passed, otherwise the end will not be differentiatedcorrectlt
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | 5.55 % | 3.831e+03 | 4.044e+03 | 212.55 | 38.55 | 36.15 |
test_proximal_jac_w7x_with_eq_update | 1.87 % | 6.486e+03 | 6.608e+03 | 121.59 | 159.86 | 159.77 |
test_proximal_freeb_jac | -0.26 % | 1.321e+04 | 1.318e+04 | -33.90 | 83.13 | 81.62 |
test_proximal_freeb_jac_blocked | 1.07 % | 7.456e+03 | 7.536e+03 | 80.13 | 72.29 | 72.20 |
test_proximal_freeb_jac_batched | -0.82 % | 7.489e+03 | 7.428e+03 | -61.05 | 72.29 | 72.70 |
test_proximal_jac_ripple | -2.18 % | 3.540e+03 | 3.463e+03 | -77.25 | 64.68 | 64.59 |
test_proximal_jac_ripple_bounce1d | 0.17 % | 3.510e+03 | 3.515e+03 | 5.80 | 75.34 | 75.43 |
test_eq_solve | 1.53 % | 1.975e+03 | 2.006e+03 | 30.28 | 93.17 | 93.26 |For the memory plots, go to the summary of |
| Returns | ||
| ------- | ||
| offset_surface : FourierRZToroidalSurface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: update this (does not return surface, only the points that would then be fit)
| keys=["R", "Z"], | ||
| grid=Grid(offset_rtz_nodes, jitable=True), | ||
| jitable=True, | ||
| build_pinv=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont know if this build_pinv does anything
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2016 +/- ##
==========================================
- Coverage 95.77% 95.52% -0.26%
==========================================
Files 101 101
Lines 27796 27881 +85
==========================================
+ Hits 26622 26632 +10
- Misses 1174 1249 +75
🚀 New features to boost your workflow:
|
Potentially useful if one desires an objective that concerns a conformal vessel to a changing eq during optimization.