Skip to content

Conversation

@dpanici
Copy link
Collaborator

@dpanici dpanici commented Nov 15, 2025

Potentially useful if one desires an objective that concerns a conformal vessel to a changing eq during optimization.

NOTE: Must have the toroidal angle as the cylindrical toroidal angle
in order for this algorithm to work properly
NOTE: this function lacks the checks of the constant_offset_surface
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only is differentiable though if params is passed, otherwise the end will not be differentiatedcorrectlt

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2025

Memory benchmark result

|               Test Name                |      %Δ      |    Master (MB)     |      PR (MB)       |    Δ (MB)    |    Time PR (s)     |  Time Master (s)   |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
  test_objective_jac_w7x                 |    5.55 %    |     3.831e+03      |     4.044e+03      |    212.55    |       38.55        |       36.15        |
  test_proximal_jac_w7x_with_eq_update   |    1.87 %    |     6.486e+03      |     6.608e+03      |    121.59    |       159.86       |       159.77       |
  test_proximal_freeb_jac                |   -0.26 %    |     1.321e+04      |     1.318e+04      |    -33.90    |       83.13        |       81.62        |
  test_proximal_freeb_jac_blocked        |    1.07 %    |     7.456e+03      |     7.536e+03      |    80.13     |       72.29        |       72.20        |
  test_proximal_freeb_jac_batched        |   -0.82 %    |     7.489e+03      |     7.428e+03      |    -61.05    |       72.29        |       72.70        |
  test_proximal_jac_ripple               |   -2.18 %    |     3.540e+03      |     3.463e+03      |    -77.25    |       64.68        |       64.59        |
  test_proximal_jac_ripple_bounce1d      |    0.17 %    |     3.510e+03      |     3.515e+03      |     5.80     |       75.34        |       75.43        |
  test_eq_solve                          |    1.53 %    |     1.975e+03      |     2.006e+03      |    30.28     |       93.17        |       93.26        |

For the memory plots, go to the summary of Memory Benchmarks workflow and download the artifact.

Returns
-------
offset_surface : FourierRZToroidalSurface
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: update this (does not return surface, only the points that would then be fit)

keys=["R", "Z"],
grid=Grid(offset_rtz_nodes, jitable=True),
jitable=True,
build_pinv=True,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont know if this build_pinv does anything

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

❌ Patch coverage is 14.77273% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.52%. Comparing base (a846c9b) to head (36e4beb).

Files with missing lines Patch % Lines
desc/objectives/_geometry.py 16.94% 49 Missing ⚠️
desc/geometry/surface.py 10.34% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
- Coverage   95.77%   95.52%   -0.26%     
==========================================
  Files         101      101              
  Lines       27796    27881      +85     
==========================================
+ Hits        26622    26632      +10     
- Misses       1174     1249      +75     
Files with missing lines Coverage Δ
desc/geometry/surface.py 91.70% <10.34%> (-5.84%) ⬇️
desc/objectives/_geometry.py 86.60% <16.94%> (-10.19%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants