-
Notifications
You must be signed in to change notification settings - Fork 2
FSW fixes to get everything compiling #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ghtController/FlightMCU/Include. Move Components.hpp to header since it contains the includes for Impl of various modules required by CubeRoverTopologyAppAc.hpp
…hed upstream with the TI FreeRTOS port
…5 and 26 on the fprime install tutorial (as of 9-27). Some questionable changes to get everything working..... Also a change to ComLogger that is TI ARM compiler specific and should be pushed upstream
…ing and LED B denotes low frequency rate group
…h s in .gitignore
|
Since some of the timing can't be tested above the HAL without external resources, added tests TIME1 and TIME2 to hardware in the loop document. |
justinnuwin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- FreeRTOS idle hook was modified to not perform no-ops anymore. Need to decide on rover operation during idle.
- Just a note for the future that Svc/BuffGndSockIf, Svc/UdpSender, Svc/UdpReceiver was removed from build list due to lack of socket support on FreeRTOS
Mikeydavidr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing jumped out when viewing the changes, and I was able to get it to compile. There are still some items I am trying to understand.
alecjprobst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, surprised that we needed to up the rate group drivers that much but values make sense.
Errors and their respective fixes:
Topology.hpp, soTopology.cppandApp/Main.cpp.Component.hppincludes these component *Impl so this include was moved toTopology.hpp.NAME_MAXorPATH_MAXinlimits.h. TODO: We may need to find a better value for, these as I just defined these macros with the values my 64-bit Linux machine uses.HOMEenvironmental variableTODO: Test that these values match wall clock timeSee Hardware In Loop Test documentCubeRoverTime component is not built: Remove all instances and connections to this component until it has been built and testedAdded back with c95a781 but includes CubeRoverTime directly rather than throughSvc/TimeTests: No unit tests for these changes, but @nrjbs87 and @alecjprobst were able to build the project without errors with these changes