Modified scripts to be agnostic to input variantID format #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, the tool requires that variants IDs (both in the input
--eqtlfile, and--vcffile) be formatted<chrom>_<pos>.... As far as I can tell, there are two reasons for this:lmfitin the fitting step.I am proposing changes that make the tool agnostic to the format of the variant IDs (I can imagine some users have VCFs that use dbSNP rsIDs, for example). Briefly, the changes are as follows:
--eqtlfile now must include two additional columns:variant_chrandvariant_posthat describe the (1-based) position of each variant. This information is then used to fetch the genotypes from the tabix-indexed VCFvariant_id_cleancolumn) that meet the formatting requirements oflmfitand are used when fitting the model.gene_id_cleanfunctionality to match that of the newvariant_id_cleancolumn. This assumes no specific formatting of the input gene IDs.