Fix Radiant Faith calculations when using Foulborn Choir of the Storm #9399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9358
Description of the problem being solved:
Radiant Faith was not calculating armour and energy shield correctly when using a Foulbourn Choir of the Storm, as resistances were not calculated before mana and
GrantReservedManaAsAuraare calculated. I've refactored the resistance calcs into a separate function delayed the aura calculation to the latest possible instance and call the resistance to be calculated before recalculating the mana and reserved mana, when themana is increased by x% of overcapped lightning resistancemod exists. Also reverts 06f7a74 as it's no longer requiredSteps taken to verify a working solution:
With Choir of the StormscreenshotsWith GreatwolfscreenshotsLink to a build that showcases this PR:
https://pobb.in/jQdfX_LgQW2w
With Choir of the Storm
With Greatwolf
Also tested using the PoB provided in #9350 (comment) (The number I get is off by 19 so may need another PoB to verify, but way closer than before)
Before screenshot:
With Choir of the Storm
With Greatwolf
After screenshot:
With Choir of the Storm
With Greatwolf
Other PoB:
Before screenshot:
After screenshot: