Skip to content

Conversation

@MohdUmar20
Copy link
Contributor

This PR is following my previous PR in which i missed to add all relevant paths to enhance its usability and it updates the vmseries.tf file to correct the path for the bootstrap template file used by the template_file data resource. The change ensures that the correct relative path is used when referencing the bootstrap.xml.template file, improving the module's portability and preventing potential issues related to incorrect file paths.

Description

This PR updates the vmseries.tf file to correct the path for the bootstrap template file used by the template_file data resource. The change ensures that the correct relative path is used when referencing the bootstrap.xml.template file, improving the module's portability and preventing potential issues related to incorrect file paths.

Motivation and Context

This change is required to ensure the Terraform module functions correctly in different environments by accurately referencing the bootstrap template file. Incorrect file paths can lead to errors during the deployment process, and this update addresses that issue.

I was not able to execute this module from different directories so thought to update it.

How Has This Been Tested?

The change was tested in a local development environment by running the Terraform configuration after updating the path. No errors were encountered, and the module successfully referenced the bootstrap.xml.template file, confirming the fix.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • [ x] I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • [ x] I have added tests to cover my changes if appropriate.
  • [x ] All new and existing tests passed.

updated the vmseries.tf file to correct the path for the bootstrap template file used by the template_file data resource.
This ensures that the correct relative path is used when referencing the bootstrap.xml.template file, improving the module's portability and preventing potential issues related to incorrect file paths.
@MohdUmar20
Copy link
Contributor Author

@mattmclimans : Please review and approve the PR.
This is following my previous PR, adding module based path in all references so that it can be used as a module from different directories.

@MohdUmarBGMEA
Copy link

Hello @mattmclimans , Can you please review and approve this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants