-
-
Notifications
You must be signed in to change notification settings - Fork 26
Users can exclude custom categories from base weight #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Users can exclude custom categories from base weight #43
Conversation
|
Wow, this looks really clean! For the 3rd task, are you looking more for UI suggestions or for more of the code side of things? |
|
Code side mainly, I have a good idea of how I want things to look. I think what I need to do (as in would be the tidiest pattern, I'm sure there are lazier ways) is have a new component which will handle users updating that one option on their category. I have zero web dev/FE/react experience so I thought I would use the EditItem component as a template, which is helpful but also confusing as I can tell there is a lot of non-explicit things happening which I don't have background context for. |
|
Oh I see what you mean. I feel you, I didn't have any react experience before working on Packstack either. I'm still definitely in the trial-and-error/guesswork phase too 😂 I'll try forking off your branch and see if I can figure something out. Although, I'm kinda wondering if there is any other things that we'd want to allow users to edit with categories, that maybe we would also want to allow users to edit the name of the category too. I don't know if there is anything else we'd want them to edit but if it's just the name and toggling whether or not it's included in the baseweight, I think we could get away with it not being in a popup at all. I'm thinking like, it could be just inline. So maybe you click an "edit" button on the category header row and then the category name becomes a text box and the 'include in baseweight' toggle also appears. The edit button turns in to a 'save' button, and a cancel button appears, kinda like how inline editing items currently works. A lot of word vomit there. We can probably chat on Slack or whatever else works for you if you wanna hash this out a bit more. |
Yeh you are probably right that there wont be much to edit for categories. Also maybe this is simpler to implement and I was just making things difficult for myself 😂 . I will hopefully have time to get back to this this weekend, I will ping you on slack. |
b981a97 to
09d927a
Compare
The weight exclusion of custom categories is not grouped with "Worn" or "Consumable" in the view's "Weight Breakdown" but added to a "Other excluded" count which is only shown when pack has items in custom excluded category.
09d927a to
d3f52e4
Compare
If category is excluded from weight, there is a help icon and a hover message
d3f52e4 to
a8494cb
Compare
This is the first bit of my work on #11.
I have worked off #42 as I like @darinalleman's toggle feature 😄 so this PR will need to wait for that one.
For this feature to be complete, I believe it needs the following:
edit itemmodal) and moving it to a new custom category, users should be able to toggle to exclude that category from the base weight.CAT NAME (excluded from base weight)or a cute icon)I have done the easy bits (see demo below), but the others are trickier: I may actually need to learn some React rather than simply going by trial-and-error/guesswork on how things wire together 😅 . Any tips/help (especially with the 3rd task which is killing me) would be awesome 🙏 .
Screen.Recording.2021-02-06.at.12.59.15.mov