Added DKG SPARQL query tool and minor code cleanup #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing in dev mode, and made some general code cleanup in the plugin-dkg-essentials.
zsculac
reviewed
Dec 23, 2025
|
|
||
| // Only allow query types supported by the DKG node | ||
| const allowedQueryTypes = ["SELECT", "CONSTRUCT"]; | ||
| if (!allowedQueryTypes.includes(parsed.queryType)) { |
Contributor
There was a problem hiding this comment.
We could normalize the case here to make sure queryTyoe is always in uppercase. So something like this:
if (!allowedQueryTypes.includes(parsed.queryType?.toUpperCase()))
zsculac
reviewed
Dec 23, 2025
| } | ||
|
|
||
| // Use validated query type | ||
| const queryType = validation.queryType || "SELECT"; |
Contributor
There was a problem hiding this comment.
if query passes validation, queryType should always be set so this fallback might hide potential bugs
zsculac
reviewed
Dec 23, 2025
Comment on lines
+199
to
+208
| const queryResult = await ctx.dkg.graph.query(query, queryType); | ||
|
|
||
| const resultText = JSON.stringify(queryResult, null, 2); | ||
|
|
||
| return { | ||
| content: [ | ||
| { | ||
| type: "text", | ||
| text: `✅ Query executed successfully\n\n**Results:**\n\`\`\`json\n${resultText}\n\`\`\``, | ||
| }, |
Contributor
There was a problem hiding this comment.
Should we use JSON.stringify when a CONSTRUCT query is called since construct returns a raw string of N-triples?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DKG SPARQL query tool to plugin-dkg-essentials, fixed the concurrency issue when running in dev mode, and made some general code cleanup in the plugin-dkg-essentials.