Add billing management section when create/edit a Role #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirumerla
approved these changes
Sep 4, 2024
Contributor
tirumerla
left a comment
tirumerla
left a comment
There was a problem hiding this comment.
lgtm, thanks. We will slate it to merge after the release of the feature.
Contributor
I think for now this is fine, You can still add it to changelog but we will release the public docs after the release anyways so its safe to add it to changelog. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settings.adocadding the manage role permission explanation.Should I include things in the
changelog.adoc? I noticed looking at the PR history that we only update it when about to release, but happy to include it in a Unreleased section or similar if that makes sense and doesn't show up in the UI.