Skip to content

Cairo: Update Stable directory #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
immrsd wants to merge 7 commits into
base: cairo/support-v3.0.0
Choose a base branch
from
Open

Cairo: Update Stable directory #755

immrsd wants to merge 7 commits into from

Conversation

@immrsd
Copy link
Contributor

@immrsd immrsd commented Dec 31, 2025

No description provided.

@immrsd immrsd self-assigned this Dec 31, 2025
@immrsd immrsd requested review from a team as code owners December 31, 2025 14:07
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 31, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

ericnordelo
ericnordelo reviewed Jan 2, 2026
View reviewed changes
packages/core/cairo/test_project/Scarb.toml
openzeppelin = { git = "https://github.com/OpenZeppelin/cairo-contracts", tag = "v2.0.0" }
assert_macros = "2.13.1"
starknet = "2.13.1"
openzeppelin_access = { git = "https://github.com/OpenZeppelin/cairo-contracts", tag = "v3.0.0-alpha.3" }
Copy link
Member

@ericnordelo ericnordelo Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should n't this be v3.0.0?

Copy link
Contributor Author

@immrsd immrsd Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to merge this PR first to bring all the changes from the alpha dir into stable. It will make reviewing the following PR with the changes required to support the audit fixes way easier. If we update the dependencies to v3.0.0 now, the test project won't be able to compile due to the new variable added to AccessControlDAR config

@immrsd immrsd requested a review from ericnordelo January 2, 2026 17:11
ericnordelo
ericnordelo approved these changes Jan 2, 2026
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericnordelo ericnordelo ericnordelo approved these changes

@ericglau ericglau Awaiting requested review from ericglau

Assignees

@immrsd immrsd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@immrsd @ericnordelo