(feat): upgrade to php8 #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdhoek1
force-pushed
the
feat/php8-upgrade
branch
5 times, most recently
from
5945819 to
e894449
Compare
mvdhoek1
force-pushed
the
feat/php8-upgrade
branch
2 times, most recently
from
2456242 to
bf9d283
Compare
mvdhoek1
force-pushed
the
feat/php8-upgrade
branch
2 times, most recently
from
e981c82 to
9001085
Compare
mvdhoek1
commented
Nov 5, 2025
| * @param Exception $exception The exception to intercept. | ||
| * @param string $method PSR‑3 log level name (e.g. 'error', 'debug'). | ||
| * | ||
| * @since NEXT |
Collaborator
Author
There was a problem hiding this comment.
@since NEXT wordt vervangen door 2.0.0 tijdens het taggen/releasen.
mvdhoek1
force-pushed
the
feat/php8-upgrade
branch
from
9001085 to
9a9d4e8
Compare
mvdhoek1
requested review from
Rovasch,
SimonvanWijhe,
hnccox-yard and
ictbeheer
mvdhoek1
force-pushed
the
feat/php8-upgrade
branch
from
9a9d4e8 to
f86e018
Compare
Rovasch
approved these changes
Nov 20, 2025
| return $this->validateBSN($bsn); | ||
| $bsn = \Yard\DigiD\Foundation\Helpers\resolve('session')->getSegment('digid')->get('bsn'); | ||
|
|
||
| return ! empty($bsn) && is_string($bsn) ? \Yard\DigiD\Foundation\Helpers\decrypt($bsn) : ''; |
| ## Description | ||
|
|
||
| Prefill GravityForms fields, based on the dutch BSN number. Retrieve personal information and place these values in the corrensponding fields. | ||
| Prefill GravityForms fields, based on the Dutch BSN number. Retrieve personal information and place these values in the corrensponding fields. |
There was a problem hiding this comment.
Misschien wat miereneukerig 😶 :
Retrieves personal information and places these values in the corrensponding fields.
Collaborator
Author
There was a problem hiding this comment.
Altijd blijven mierenneuken 🐜
ictbeheer
reviewed
Nov 24, 2025
| return $this->validateBSN($bsn); | ||
| } | ||
|
|
||
| if ($bsn = $this->samlDigiD()) { |
Contributor
There was a problem hiding this comment.
Is dit echt nog nodig? De SAML plugin gebruikt nu ook de IDPUserData
ictbeheer
reviewed
Nov 24, 2025
| ], | ||
| ], | ||
| [ | ||
| 'title' => esc_html__('Berichtenverkeer logboek', 'prefill-gravity-forms'), |
Contributor
There was a problem hiding this comment.
Je kan ook op de native gravity forms logger inhaken, GFAddOn heeft log_error() en log_debug()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.