Allow sorting parameters, mainly to get PDC items sorted by name #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… universally implemented
mvdhoek1
requested review from
Rovasch,
SimonvanWijhe,
ictbeheer and
rivanuff
mvdhoek1
reviewed
Dec 2, 2025
| return true; | ||
| } | ||
|
|
||
| protected function getOrderClause(mixed $orderBy, mixed $order) |
Contributor
There was a problem hiding this comment.
mixed als typehint kunnen we nog niet toepassen aangezien deze plug-in ook nog compatible moet zijn met php7.
Contributor
Author
There was a problem hiding this comment.
excusé; niet goed gekeken naar de autocomplete; dat moet natuurlijk gewoon string zijn.
mvdhoek1
reviewed
Dec 2, 2025
Contributor
mvdhoek1
left a comment
mvdhoek1
left a comment
There was a problem hiding this comment.
Ik kijk er later nog even naar, iets met te weinig tijd.
Rovasch
approved these changes
Dec 10, 2025
Contributor
Rovasch
left a comment
Rovasch
left a comment
There was a problem hiding this comment.
Alleen de comments op ln 128, 133 en 141 lijken me niet nodig.
Contributor
Author
|
Als jullie de comments niet willen, mag je ze van mij weghalen. Mijn insteek is; als er een reden is te denken; he, wat gebeurt hier? dan is een comment gewenst. Het is aan jullie, jullie plugin, jullie regels :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sorting parameters, mainly to get PDC items sorted by name, but universally implemented.
While retaining the pre-existing sorting for backward compatibility, the following URL parameters now determine sorting;
orderby-> the field or comma sep fields to sort on, example;post_date,IDorder-> the order, ASC or DESC, example;DESC,ASCsort by date DESC, ID DESC can be achieved by
orderby=post_date,ID&order=DESC,DESCbut also by
orderby=post_date,ID&order=DESCSorting by post-title, ASC
orderby=post_title&order=ASCetc.
First commit changed whitespace because the supplied .editorconfig file does not match the actual coding standards used. Will correct and do second commit.