Fix http-proxy-agent / https-proxy-agent imports in htmlOnlyFetcher #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I can have a look at the changelog (although, should I set a new version myself?), but not sure why the windows tests would crash :/ |
Ndpnt
approved these changes
Nov 19, 2025
Contributor
|
Thanks for this fix @LVerneyEC 👍 |
LVerneyEC
added a commit
to LVerneyEC/engine
that referenced
this pull request
Nov 24, 2025
Counterpart of OpenTermsArchive#1206 for reporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1205
Please note that this code was pre-existing to the recent changes of proxy handling. Tested and working for me on Node v20, but please do check that I did not miss any potential side effects on other node versions / setups.