Skip to content

Conversation

@matiasperrone-exo
Copy link
Contributor

@matiasperrone-exo matiasperrone-exo self-assigned this Oct 14, 2025
@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Oct 14, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2tagsapicontroller branch from c265146 to c35ff80 Compare October 14, 2025 17:56
@matiasperrone-exo matiasperrone-exo added the review Need reviewing from the developer label Nov 10, 2025
@matiasperrone-exo matiasperrone-exo removed the review Need reviewing from the developer label Nov 18, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2tagsapicontroller branch from b81a87d to a1f1c38 Compare November 20, 2025 21:54
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone-exo The security schema needs to be updated/created with the correct scopes.

Also, your missing Security on GET /api/v1/tags/{id}
This endpoint has NO security parameter, but the seeder shows it requires authentication:

operationIds needed

Endpoint Suggested operationId
GET /api/v1/tags getAllTags
GET /api/v1/tags/{id} getTag
POST /api/v1/tags createTag
PUT /api/v1/tags/{id} updateTag
DELETE /api/v1/tags/{id} deleteTag

Missing x: ['required-groups'] for Write Operations
POST, PUT, DELETE endpoints require authorization groups per the seeder:
x: [
'required-groups' => [
IGroup::SuperAdmins,
IGroup::Administrators,
IGroup::SummitAdministrators,
]
],

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2tagsapicontroller branch from f713895 to a1c41ab Compare December 3, 2025 19:21
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong x: Parameter Key
All 3 write endpoints use 'authz_groups' instead of the project standard 'required-groups'. Please change these to 'required-groups'

Affected locations: createTag, updateTag, deleteTag

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2tagsapicontroller branch from 47724c0 to 0ab93f0 Compare December 4, 2025 17:58
@matiasperrone-exo
Copy link
Contributor Author

Thanks @caseylocker for the comments. Now is ready to review again

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2tagsapicontroller branch from 0ab93f0 to 391fe7f Compare December 5, 2025 14:55
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@smarcet
Copy link
Collaborator

smarcet commented Dec 16, 2025

@matiasperrone please rebase against main and review conflicts

1 similar comment
@smarcet
Copy link
Collaborator

smarcet commented Dec 16, 2025

@matiasperrone please rebase against main and review conflicts

@smarcet smarcet force-pushed the main branch 4 times, most recently from c6ecdd0 to 728ae67 Compare December 17, 2025 00:43
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---main---oauth2tagsapicontroller branch from 391fe7f to b755506 Compare December 29, 2025 19:44
Signed-off-by: Matias Perrone <github@matiasperrone.com>
@matiasperrone-exo
Copy link
Contributor Author

@smarcet the branch is now rebased and conflicts free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants