Skip to content

Conversation

@matiasperrone-exo
Copy link
Contributor

@matiasperrone-exo matiasperrone-exo self-assigned this Oct 9, 2025
@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Oct 13, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitsponsorshiptypeapicontroller branch from 4f42a74 to 9c71954 Compare October 14, 2025 17:47
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc generation is failing.
Verify parameter references exist for:
new OA\Parameter(ref: '#/components/parameters/page'),
new OA\Parameter(ref: '#/components/parameters/per_page'),
Or create them.

Also verify security schema exists for 'OAuth2'

@matiasperrone-exo matiasperrone-exo added the review Need reviewing from the developer label Nov 10, 2025
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitsponsorshiptypeapicontroller branch from 4e15e16 to 2a194d4 Compare November 13, 2025 20:37
@matiasperrone-exo
Copy link
Contributor Author

@caseylocker The security schema for the controller was moved to its own file and the doc generation is working now

@matiasperrone-exo matiasperrone-exo removed the review Need reviewing from the developer label Nov 18, 2025
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone-exo Namespace issue in the controller.
// Current (WRONG)
namespace App\Swagger\Security;

// Required (CORRECT)
namespace App\Swagger\schemas;

Also missing operationIds. Suggestions below:

GET /api/v1/summits/{id}/sponsorships-types getAllSponsorshipTypes
POST /api/v1/summits/{id}/sponsorships-types createSponsorshipType
GET /api/v1/summits/{id}/sponsorships-types/{type_id} getSponsorshipType
PUT /api/v1/summits/{id}/sponsorships-types/{type_id} updateSponsorshipType
DELETE /api/v1/summits/{id}/sponsorships-types/{type_id} deleteSponsorshipType
POST .../badge-image addSponsorshipTypeBadgeImage
DELETE .../badge-image deleteSponsorshipTypeBadgeImage

@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitsponsorshiptypeapicontroller branch from 48a1884 to 5f34317 Compare December 5, 2025 14:37
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@smarcet
Copy link
Collaborator

smarcet commented Dec 16, 2025

@matiasperrone please rebase against main and fix the conflicts many thanks

@smarcet smarcet force-pushed the main branch 4 times, most recently from c6ecdd0 to 728ae67 Compare December 17, 2025 00:43
@matiasperrone-exo matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller---apis---protected---summit---oauth2summitsponsorshiptypeapicontroller branch from 5f34317 to d111df8 Compare December 29, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants