-
Notifications
You must be signed in to change notification settings - Fork 2
Feature | Extend Swagger Coverage for controller OAuth2SummitSponsorshipTypeApiController
#393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4f42a74 to
9c71954
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc generation is failing.
Verify parameter references exist for:
new OA\Parameter(ref: '#/components/parameters/page'),
new OA\Parameter(ref: '#/components/parameters/per_page'),
Or create them.
Also verify security schema exists for 'OAuth2'
4e15e16 to
2a194d4
Compare
|
@caseylocker The security schema for the controller was moved to its own file and the doc generation is working now |
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matiasperrone-exo Namespace issue in the controller.
// Current (WRONG)
namespace App\Swagger\Security;
// Required (CORRECT)
namespace App\Swagger\schemas;
Also missing operationIds. Suggestions below:
| GET /api/v1/summits/{id}/sponsorships-types | getAllSponsorshipTypes |
|---|---|
| POST /api/v1/summits/{id}/sponsorships-types | createSponsorshipType |
| GET /api/v1/summits/{id}/sponsorships-types/{type_id} | getSponsorshipType |
| PUT /api/v1/summits/{id}/sponsorships-types/{type_id} | updateSponsorshipType |
| DELETE /api/v1/summits/{id}/sponsorships-types/{type_id} | deleteSponsorshipType |
| POST .../badge-image | addSponsorshipTypeBadgeImage |
| DELETE .../badge-image | deleteSponsorshipTypeBadgeImage |
48a1884 to
5f34317
Compare
caseylocker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
|
@matiasperrone please rebase against main and fix the conflicts many thanks |
c6ecdd0 to
728ae67
Compare
…TypeApiController`
…nActionTypeApiController`
Signed-off-by: Matias Perrone <github@matiasperrone.com>
5f34317 to
d111df8
Compare
Task:
Ref: https://app.clickup.com/t/86b6wkh3t