feat: user creation endpoint #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: romanetar <roman_ag@hotmail.com>
romanetar
force-pushed
the
feature/user-creation-endpoint
branch
from
0bb1642 to
40aa5d9
Compare
smarcet
reviewed
Jan 23, 2025
| $data = [ | ||
| 'first_name' => $first_name, | ||
| 'last_name' => 'test_'. str_random(16), | ||
| 'email' => 'test_'. str_random(16) . '@test.com', |
Collaborator
There was a problem hiding this comment.
you need to set groups and check if its works
smarcet
reviewed
Jan 23, 2025
|
|
||
| $content = $response->getContent(); | ||
| $response = json_decode($content); | ||
| $this->assertTrue($response->first_name == $first_name); |
Collaborator
There was a problem hiding this comment.
check groups and rest of the set fields
smarcet
requested changes
Jan 23, 2025
Collaborator
smarcet
left a comment
smarcet
left a comment
There was a problem hiding this comment.
@romanetar please review comments
Signed-off-by: romanetar <roman_ag@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://tipit.avaza.com/project/view#!tab=task-pane&groupby=MyTaskDueDate&view=vertical&task=3720004&stafilter=NotComplete&fileview=grid
Signed-off-by: romanetar roman_ag@hotmail.com