Skip to content

Conversation

@hhvrc
Copy link
Contributor

@hhvrc hhvrc commented Nov 22, 2024

No description provided.

@hhvrc hhvrc requested a review from LucHeart November 22, 2024 11:46
@hhvrc hhvrc self-assigned this Nov 22, 2024
@hhvrc
Copy link
Contributor Author

hhvrc commented Nov 22, 2024

Testing:

  • Migration with no ComplexMigrations work
  • Migration with one or more ComplexMigrations work
  • If ComplexMigration fails in beforeup/beforedown, the migration should not proceed.
  • If ComplexMigration fails in afterup/afterdown the next run should try to apply the complex migration again.

@hhvrc
Copy link
Contributor Author

hhvrc commented Nov 22, 2024

TODO

We need to write to a migration record in the database which complex migrations we are about to do before we do them (Like a DB WAL) so we can retry if failed.

We need to wrap all the up/down handlers in transactions.

@hhvrc hhvrc closed this Nov 22, 2024
@hhvrc hhvrc deleted the feature/complex-migrations-support branch November 22, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants