Remove the underscore from printer name if it is the last and not the only character #1472
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the backend reports the device name “Canon LBP3200 (captusb)”, the parentheses and their contents are removed, leaving a space at the end, which is replaced with an underscore, resulting in “Canon_LBP3200_”.
This underscore at the end is extremely annoying.
Similar code in cups/dest.c:
cups/cups/dest.c
Lines 3971 to 3977 in 2f6411e
You can test this patch using a dummy backend:
Ref darkvision77/captppd#4 (comment)