Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 4, 2025

Build logs from sublibraries and the full contrib log were not being preserved as artifacts, making debugging failures difficult.

Changes

  • Platform name mapping: Adds step to map matrix.os to friendly names (linux, linux_arm, macos, windows)
  • Log collection: Copies and renames logs from both build directories:
    • contrib-build/contrib_build.logcontrib_build_all.log
    • contrib-build-openmp/contrib_build.logcontrib_build_openmp.log
  • Artifact upload: Uses actions/upload-artifact@v4 with if: always() to ensure logs are uploaded even on failure

Artifacts are named build-logs-{platform} (e.g., build-logs-linux_arm) and automatically zipped by the action.

Original prompt

Make sure that all the logs from the different sublibraries and the full contrib log are uploaded as build artefacts. They can be zipped per build platform (linux, linux_arm ...)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: jpfeuffer <8102638+jpfeuffer@users.noreply.github.com>
Copilot AI changed the title [WIP] Ensure all logs are uploaded as build artifacts Upload build logs as artifacts per platform Dec 4, 2025
Copilot AI requested a review from jpfeuffer December 4, 2025 21:32
@poshul
Copy link
Contributor

poshul commented Dec 8, 2025

@jpfeuffer The logs this produces look good to me. Do you think it's good to merge?

@jpfeuffer jpfeuffer marked this pull request as ready for review December 8, 2025 11:35
@poshul poshul merged commit dc7f54a into master Dec 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants