Adds Gradle build that delegates to existing Ant build #214
Conversation
NicoPiel
force-pushed
the
feature/gradle-build-ant
branch
2 times, most recently
from
6a6e3c7 to
ddf0ada
Compare
mgaffigan
left a comment
mgaffigan
left a comment
There was a problem hiding this comment.
Other issues to address
- CI build scripts need updated (.github/workflow/...)
- Readme/Contributor documents need updated
- ant mirth-build build target needs to be updated to block build outside of gradle with migration guidance in error message
| // Pass Gradle properties to Ant | ||
| project.findProperty("disableSigning")?.let { | ||
| ant.properties["disableSigning"] = it.toString() | ||
| } | ||
|
|
||
| project.findProperty("disableTests")?.let { | ||
| ant.properties["disableTests"] = it.toString() | ||
| } |
There was a problem hiding this comment.
Are there other properties we need to be passing?
There was a problem hiding this comment.
Good question. I'm not sure. These are the only two I use and the only two available in mirth-build.xml, afaia.
There was a problem hiding this comment.
I know JUnit supports some properties for running specific tests instead of the whole suite, but I doubt anyone actually uses that. I have in the past, but I would need to look them up to even identify what they are called, because it's not something I do frequently. I wouldn't hold up this PR for that.
There was a problem hiding this comment.
This commit added disableSigning as well as cert and keystore_property_file
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Adds a top-level Gradle build that imports the existing Ant build to enable a gradual migration to Gradle while still using Ant for current tasks. Configures Ant to run JUnit (including ant-junit4) and exposes select Gradle properties to Ant; renames conflicting Ant targets to avoid collisions and makes the Gradle build task delegate to the Ant build target. Also adds placeholder Gradle files for subprojects and bumps the configured Gradle SDK version. Co-authored-by: Mitch Gaffigan <mitch.gaffigan@comcast.net> Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
Signed-off-by: Nico Piel <nico.piel@hotmail.de>
NicoPiel
force-pushed
the
feature/gradle-build-ant
branch
3 times, most recently
from
4018468 to
6284f3b
Compare
Changes the root project name to a lowercase value to avoid case-related build/tooling issues (improves compatibility with Gradle/Ant and CI environments). Signed-off-by: Nico Piel <nico.piel@hotmail.de>
| # Add key=value pairs of SDKs to use below | ||
| java=17.0.17.fx-zulu | ||
| ant=1.10.14 | ||
| gradle=9.2.1 |
There was a problem hiding this comment.
I don't think this change is necessary. The gradle version for the project is handled by the gradle wrapper.
| // Pass Gradle properties to Ant | ||
| project.findProperty("disableSigning")?.let { | ||
| ant.properties["disableSigning"] = it.toString() | ||
| } | ||
|
|
||
| project.findProperty("disableTests")?.let { | ||
| ant.properties["disableTests"] = it.toString() | ||
| } |
There was a problem hiding this comment.
I know JUnit supports some properties for running specific tests instead of the whole suite, but I doubt anyone actually uses that. I have in the past, but I would need to look them up to even identify what they are called, because it's not something I do frequently. I wouldn't hold up this PR for that.
| // Pass Gradle properties to Ant | ||
| project.findProperty("disableSigning")?.let { | ||
| ant.properties["disableSigning"] = it.toString() | ||
| } | ||
|
|
||
| project.findProperty("disableTests")?.let { | ||
| ant.properties["disableTests"] = it.toString() | ||
| } |
There was a problem hiding this comment.
This commit added disableSigning as well as cert and keystore_property_file
3 participants
Adds an initial Gradle build system that delegates to the existing Ant build to enable gradual migration and tooling improvements.
Highlights:
Why:
Notes / Next steps: