-
Notifications
You must be signed in to change notification settings - Fork 42
Added docker build and quick-start #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I updated #40 with how I think the "official" docker container should be implemented. However, I really like the idea of what is presented here to use docker as a developer tool for building and testing. I've also responded to some of your questions here #2 (comment) |
|
@tonygermano, I'm no longer aware of issues outside of the registry name (presumably someone owns the official URL?). Differences I'm aware of relative to the original repo:
Happy to discuss as needed. Every compose file, kubernetes deployment, etc... that I've tested doesn't notice the difference between this and stock. |
|
@mgaffigan I pulled your launcher script out of this PR, made significant changes, and put it in its own PR in #119 . I think it is useful outside of a docker context, and it can still be used with docker. Would you mind reviewing it and giving any feedback? |
|
@tonygermano, Excellent! I'd love to see that merged and agree it is useful outside of docker. |
a3709ea to
6b7246f
Compare
|
I've updated the PR to depend upon #119 for oieserver.sh and match the conventions of #126 assuming that has more community input. Currently blocked by merge of: #119 and #126 Process used for testing:
|
Don't link to #126, it is still a draft and not ready for review. |
25d21a6 to
944208e
Compare
DEVELOPERS.md
Outdated
| ## Build and run locally | ||
|
|
||
| To build the solution, you must have a Java 1.8 JDK+FX and Apache Ant. This | ||
| can be installed by [sdkman](https://sdkman.io/) by executing `sdk env install`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC SDKMan isn't supported on windows. Do you need separate *nix, mac, and winderz instructions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think *nix and mac can go as is, but windows should be clarified, yes. This also needs to be updated for the new Java 17 minimum build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated language to address windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI the cli interface for sdkman start to be rewrite in Rust and also available on Windows.
a296c57 to
ed66e29
Compare
tonygermano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither of these comments are blocking:
- This does not work in my environment (podman installed from package manager in debian bookworm) because of the
COPY --excludesyntax. If I was using docker instead, I think it still would not work without some modification to my environment to tell it to use BuildKit. - At some point the content of
DEVELOPERS.mdwill need to be reconciled with the changes toCONTRIBUTING.mdin #201 , and likely most of this "how to build" documentation should be moved to https://github.com/OpenIntegrationEngine/docs-website where it can be better organized rather than living in this repo.
DEVELOPERS.md
Outdated
| `-DdisableSigning=true` to support JWS signatures and run MCAL passing `-k -d` | ||
| to make it ignore self-signed certificates. Launchers like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `-DdisableSigning=true` to support JWS signatures and run MCAL passing `-k -d` | |
| to make it ignore self-signed certificates. Launchers like | |
| `-DdisableSigning=true` to sign the client jars and run MCAL from the cli | |
| passing `-k` to make it ignore self-signed certificates. Launchers like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion in Github, I updated to refer to the docs site, and only kept a reference to Ballista.
Adds docker build and configure-from-env script to configure OIE server based on environment variables at container startup time. Issue: OpenIntegrationEngine#40 Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
ed66e29 to
37d46c7
Compare
I updated the syntax line to be more specific - hopefully that will give a better error in podman if --exclude is not supported.
Agreed. Updated DEVELOPERS.md to reference the docs website. Not sure about reconciling 201. I wouldn't mind moving that reconciliation to #201, since I'm trying for a small PR here that delivers the dockerfile. |
While this might be somewhat responsive to #40, it is primarily just to provide a quick-start way for a developer to build and test. While trying to address Issue 5 I had hours of challenges getting things building happily - and shifted to docker as an escape hatch.
I do not expect this PR is ready to merge as is, but wanted to get something posted publicly. Known issues include:
That said, it does work to the point of passing tests, running server, client, and simple message processing.
I'm new to the project, so if I've missed a step please let me know.