Added timeout POC for LCD backlight (untested) #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set via RAPI ATR command
Author
|
Pretty sure this isn't the right way to do this.. probably better to have created a branch. This PR also includes the feature to allow both relays to be controlled independently and adds the RAPI command 'R' (relay2 Enable) which enables the 2nd relay if set to 1. Code defaults to second relay enabled so is a non-breaking change. This will allow future functionality around PV divert being able to chose if either single or three phase charging, and may give flexibility for other things making the relay2 output useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've created a POC for a timeout for the LCD backlight.
Note, I've not tested this, but I think it should work. It needs tidied up to make it configurable (if only I knew how).
Can you let me me know what you think and if this could be the basis for this feature ?