Fix menu not cleared outside content area #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When closing the menu, sdl_miyoomini_clear_border is not called. When the menu renders outside of the content area (e.g. with stretched menu and non 4:3 content), the menu will remain on the framebuffer. There is an existing check (probably from dingux) that checks if the menu is closed and `was_in_menu` is set (meaning this is the first frame where the menu is closed), we clear the border. However, the miyoomini version does not set `was_in_menu`, so that logic was not triggered. By saving `was_in_menu`, we can also only set the stOpt.eRotate on the first frame that the menu opens, and the first frame after the menu is closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When closing the menu, sdl_miyoomini_clear_border is not called. When the menu renders outside of the content area (e.g. with stretched menu and non 4:3 content), the menu will remain on the framebuffer.
There is an existing check (probably from dingux) that checks if the menu is closed and
was_in_menuis set (meaning this is the first frame where the menu is closed), we clear the border. However, the miyoomini version does not setwas_in_menu, so that logic was not triggered.By saving
was_in_menu, we can also only set the stOpt.eRotate on the first frame that the menu opens, and the first frame after the menu is closed.